[SPARK-44814][CONNECT][PYTHON]Test to protect from faulty protobuf versions#42498
Closed
grundprinzip wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-44814][CONNECT][PYTHON]Test to protect from faulty protobuf versions#42498grundprinzip wants to merge 2 commits intoapache:masterfrom
grundprinzip wants to merge 2 commits intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
Aug 21, 2023
Member
|
Seems like it dose trigger sth :-). https://github.com/grundprinzip/spark/actions/runs/5870189292/job/15916811394#step:12:1425 |
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Hi, @grundprinzip . Do you want to proceed or close this PR? Please let us know.
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Certain versions of protobuf contain a bug that triggers a segmentation fault when the protobuf messages are deeply nested. This patch adds a test for this case to avoid hitting it if we intend to upgrade our dependencies to such a version.
Why are the changes needed?
Stability
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT