Skip to content

[SPARK-44740][CONNECT][FOLLOW] Fix metadata values for Artifacts#42537

Closed
grundprinzip wants to merge 1 commit intoapache:masterfrom
grundprinzip:spark-44740-follow
Closed

[SPARK-44740][CONNECT][FOLLOW] Fix metadata values for Artifacts#42537
grundprinzip wants to merge 1 commit intoapache:masterfrom
grundprinzip:spark-44740-follow

Conversation

@grundprinzip
Copy link
Contributor

What changes were proposed in this pull request?

This is a followup for a previous fix where we did not properly propagate the metadata from the main client into the dependent stubs.

Why are the changes needed?

compatibility

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing UT

Copy link
Contributor

@hvanhovell hvanhovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhengruifeng pushed a commit that referenced this pull request Aug 18, 2023
### What changes were proposed in this pull request?
This is a followup for a previous fix where we did not properly propagate the metadata from the main client into the dependent stubs.

### Why are the changes needed?
compatibility

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Existing UT

Closes #42537 from grundprinzip/spark-44740-follow.

Authored-by: Martin Grund <martin.grund@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
(cherry picked from commit b37daf5)
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
@zhengruifeng
Copy link
Contributor

merged to master and branch-3.5

valentinp17 pushed a commit to valentinp17/spark that referenced this pull request Aug 24, 2023
### What changes were proposed in this pull request?
This is a followup for a previous fix where we did not properly propagate the metadata from the main client into the dependent stubs.

### Why are the changes needed?
compatibility

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Existing UT

Closes apache#42537 from grundprinzip/spark-44740-follow.

Authored-by: Martin Grund <martin.grund@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants