[SPARK-44870][SQL] Convert HashAggregate to SortAggregate if all grouping expressions are in child output orderings#42557
Closed
wankunde wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-44870][SQL] Convert HashAggregate to SortAggregate if all grouping expressions are in child output orderings#42557wankunde wants to merge 1 commit intoapache:masterfrom
wankunde wants to merge 1 commit intoapache:masterfrom
Conversation
…ping expressions are in child output orderings
Contributor
Author
|
Hi, @wangyum Could you help to review this PR? Thanks |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When we try to convert a HashAggregate to SortAggregate in rule ReplaceHashWithSortAgg, add a new function
SortOrder.satisfiesExpressions(orderings: Seq[SortOrder], groupExpressions: Seq[Expression])to determine if the child output ordering satisfies the grouping expressions.example query 1 :
The grouping expressions are b, a, and the child output orderings are a.asc, b.asc, SortOrder.satisfiesExpressions() is true.
example query 2 :
The grouping expressions are a, b, d, and the child output orderings are a.asc, b.asc, but we still can find d in a.asc.children, so SortOrder.satisfiesExpressions() is true..
Why are the changes needed?
Convert more HashAggregate to SortAggregate to improve aggregate performance.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added UT