Skip to content

[SPARK-44728][PYTHON][DOCS]Add examples to approxQuantile docstring#42637

Closed
michaelzhan-db wants to merge 4 commits intoapache:masterfrom
michaelzhan-db:approxQuantile-doc
Closed

[SPARK-44728][PYTHON][DOCS]Add examples to approxQuantile docstring#42637
michaelzhan-db wants to merge 4 commits intoapache:masterfrom
michaelzhan-db:approxQuantile-doc

Conversation

@michaelzhan-db
Copy link
Contributor

@michaelzhan-db michaelzhan-db commented Aug 23, 2023

What changes were proposed in this pull request?

Added examples to DataFrame.approxQuantile. Also updated the expected input description to reflect input types.

Why are the changes needed?

To improve pyspark documentation

Does this PR introduce any user-facing change?

No.

How was this patch tested?

DocTest.

Was this patch authored or co-authored using generative AI tooling?

No

@michaelzhan-db michaelzhan-db marked this pull request as draft August 23, 2023 22:40
@michaelzhan-db michaelzhan-db changed the title Add examples to approxQuantile docstring [SPARK-44728][PYTHON][DOCS]Add examples to approxQuantile docstring Aug 24, 2023
@michaelzhan-db michaelzhan-db marked this pull request as ready for review August 24, 2023 19:54
@zhengruifeng
Copy link
Contributor

To test this docstring, you can run

python/run-tests --python-executables python3 --testnames 'pyspark.sql.dataframe'

in your local env

michaelzhan-db and others added 2 commits August 29, 2023 09:14
Co-authored-by: Ruifeng Zheng <ruifengz@foxmail.com>
@zhengruifeng
Copy link
Contributor

thanks, merged to master

@zhengruifeng
Copy link
Contributor

oops, @michaelzhan-db let's don't use the umbrella ticket SPARK-42728, you could create a subtask under it next time :)

@zhengruifeng
Copy link
Contributor

the ticket should be SPARK-44949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants