[SPARK-43943][FOLLOWUP] Correct a function alias#42642
Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-43943][FOLLOWUP] Correct a function alias#42642zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Conversation
zhengruifeng
changed the title
zhengruifeng
added a commit
that referenced
this pull request
Aug 24, 2023
### What changes were proposed in this pull request?
Correct a function alias
### Why are the changes needed?
it should be `sign`
### Does this PR introduce _any_ user-facing change?
actually no, since `pyspark.sql.connect.function` shares the same namespace with `pyspark.sql.function`
also manually check (before this PR)
```
Welcome to
____ __
/ __/__ ___ _____/ /__
_\ \/ _ \/ _ `/ __/ '_/
/__ / .__/\_,_/_/ /_/\_\ version 4.0.0.dev0
/_/
Using Python version 3.10.11 (main, May 17 2023 14:30:36)
Client connected to the Spark Connect server at localhost
SparkSession available as 'spark'.
In [1]: from pyspark.sql import functions as sf
In [2]: sf.sign
Out[2]: <function pyspark.sql.functions.signum(col: 'ColumnOrName') -> pyspark.sql.column.Column>
In [3]: sf.sigh
---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
Cell In[3], line 1
----> 1 sf.sigh
AttributeError: module 'pyspark.sql.functions' has no attribute 'sigh'
```
### How was this patch tested?
CI
### Was this patch authored or co-authored using generative AI tooling?
NO
Closes #42642 from zhengruifeng/spark_43943_followup.
Authored-by: Ruifeng Zheng <ruifengz@apache.org>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
(cherry picked from commit c660eb3)
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Contributor
Author
|
merged to master and branch-3.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Correct a function alias
Why are the changes needed?
it should be
signDoes this PR introduce any user-facing change?
actually no, since
pyspark.sql.connect.functionshares the same namespace withpyspark.sql.functionalso manually check (before this PR)
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
NO