[SPARK-44964][ML][CONNECT][TESTS] Clean up pyspark.ml.connect.functions doctest#42679
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-44964][ML][CONNECT][TESTS] Clean up pyspark.ml.connect.functions doctest#42679HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Conversation
HyukjinKwon
commented
Aug 25, 2023
| # | ||
|
|
||
| """Spark Connect Python Client - ML module""" | ||
| from pyspark.sql.connect.utils import check_dependencies |
Member
Author
There was a problem hiding this comment.
and we check the required dependency at the top level of module when it's imported.
HyukjinKwon
changed the title
Contributor
|
@HyukjinKwon I think this test is working? https://github.com/apache/spark/actions/runs/5972917734/job/16204296750 |
HyukjinKwon
commented
Aug 26, 2023
| del pyspark.ml.connect.functions.vector_to_array.__doc__ | ||
|
|
||
| # TODO: spark.createDataFrame should support UDT | ||
| del pyspark.ml.connect.functions.array_to_vector.__doc__ |
Member
Author
There was a problem hiding this comment.
that works but none of tests are actually running :-)
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to clean up
pyspark.ml.connect.functionsdoctest. All of the tests under that are being skipped.Why are the changes needed?
To remove unused test codes.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Manually ran the tests via:
Was this patch authored or co-authored using generative AI tooling?
No