[SPARK-44982][CONNECT] Mark Spark Connect server configurations as static#42695
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-44982][CONNECT] Mark Spark Connect server configurations as static#42695HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Conversation
yaooqinn
approved these changes
Aug 28, 2023
grundprinzip
approved these changes
Aug 28, 2023
Member
Author
|
Merged to master and branch-3.5. I am merging this to 3.5 too as #42694 would need this, and I believe the risk is low. |
HyukjinKwon
added a commit
that referenced
this pull request
Aug 28, 2023
…atic This PR proposes to mark all Spark Connect server configurations as static configurations. They are already static configurations, and cannot be set in runtime configuration (by default), see also https://github.com/apache/spark/blob/4a4856207d414ba88a8edabeb70e20765460ef1a/sql/core/src/main/scala/org/apache/spark/sql/RuntimeConfig.scala#L164-L167 No, they are already static configurations. Existing unittests. No. Closes #42695 from HyukjinKwon/SPARK-44982. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 5b69dfd) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Member
|
+1 for backporting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to mark all Spark Connect server configurations as static configurations.
Why are the changes needed?
They are already static configurations, and cannot be set in runtime configuration (by default), see also
spark/sql/core/src/main/scala/org/apache/spark/sql/RuntimeConfig.scala
Lines 164 to 167 in 4a48562
Does this PR introduce any user-facing change?
No, they are already static configurations.
How was this patch tested?
Existing unittests.
Was this patch authored or co-authored using generative AI tooling?
No.