[SPARK-42304][SQL] Rename _LEGACY_ERROR_TEMP_2189 to GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION

[valentinp17]

What changes were proposed in this pull request?

This PR proposes to assign name to _LEGACY_ERROR_TEMP_2189, "GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION".

Why are the changes needed?

Assign proper name to LEGACY_ERROR_TEMP*

Does this PR introduce any user-facing change?

No

How was this patch tested?

./build/sbt "testOnly org.apache.spark.SparkThrowableSuite"

Was this patch authored or co-authored using generative AI tooling?

No

[valentinp17]

@MaxGekk @itholic PTAL when you find some time.

[itholic]

Can we add a dedicated test for this error class??

[itholic]

Is the getTablesByType only function that is not supported by Hive 2.2 and lower?? Otherwise I feel the "FUNCTION" in the error class name might too generic.

[valentinp17]

I guess I agree.
I can rename to "GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION" if it's not too long

[valentinp17]

Can we add a dedicated test for this error class??

I will try to do it

I think this test should cover getTablesByType()

spark/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala

Line 1631 in 76a32d3

override def getTablesByType(

[dongjoon-hyun]

+1, LGTM. Thank you, @valentinp17 and @itholic .
Merged to master for Apache Spark 4.0.0.

[dongjoon-hyun]

Do you have ASF JIRA account, @valentinp17 ?

I can assign https://issues.apache.org/jira/browse/SPARK-42304 to you if you have the ID.

[valentinp17]

Do you have ASF JIRA account, @valentinp17 ?

I can assign https://issues.apache.org/jira/browse/SPARK-42304 to you if you have the ID.

Not yet. I sent a request to create ASF JIRA account.
Can I tag you here to assign this Jira ticket later?

[valentinp17]

Thank you, @dongjoon-hyun
I created ASF JIRA account. Jira username: valentinp17

[dongjoon-hyun]

I added to you the Apache Spark contributor group and assigned SPARK-42304 to you.
Welcome to the Apache Spark community, @valentinp17 !

[itholic]

Welcome, @valentinp17 !

[itholic]

I will try to do it
I think this test should cover getTablesByType()

Btw, I believe you can add a test as your next work if you're interested in! :-)

[valentinp17]

@itholic Hi!
Of course, I'm interested in!
I'm unsure whether I should create a new Jira for these changes or not. So I decided to show tests in my fork repo first.
PTAL valentinp17@d44216b

cc @MaxGekk @cxzl25

[valentinp17]

Additional observation:

Pull request template message looks outdated:

8. If you want to add or modify an error type or message, please read the guideline first in 'core/src/main/resources/error/README.md'

I suppose it should link to 'common/utils/src/main/resources/error/README.md' instead. If I'm right, I can create PR for this too.

[itholic]

I'm unsure whether I should create a new Jira for these changes or not

We can just reuse the existing JIRA, or we can create a new one. This usually depends on the size of the task, but it's totally up to you :-).

In case reusing the existing JIRA, we typically add a [FOLLOWUP] tag, such as "[SPARK-42304][FOLLOWUP][SQL] Add test for GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION"

I suppose it should link to 'common/utils/src/main/resources/error/README.md' instead. If I'm right, I can create PR for this too.

Yeah, seems the link is broken. Let's fix it!