[SPARK-44750][PYTHON][CONNECT][TESTS][FOLLOW-UP] Avoid creating session twice in SparkConnectSessionWithOptionsTest #42747
Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
zhengruifeng
force-pushed
the
minor_test_ut
branch
from
d4b736a to
b6c1dab
Compare
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 1, 2023
…on twice in `SparkConnectSessionWithOptionsTest` ### What changes were proposed in this pull request? Avoid creating session twice in `SparkConnectSessionWithOptionsTest` ### Why are the changes needed? the session created in `ReusedConnectTestCase#setUpClass` is not used, so no need to inherit ### Does this PR introduce _any_ user-facing change? no, test-only ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes #42747 from zhengruifeng/minor_test_ut. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 8c27de6) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Member
|
Merged to main/3.5. Thank you, @zhengruifeng . |
Contributor
Author
|
thank you @dongjoon-hyun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoid creating session twice in
SparkConnectSessionWithOptionsTestWhy are the changes needed?
the session created in
ReusedConnectTestCase#setUpClassis not used, so no need to inheritDoes this PR introduce any user-facing change?
no, test-only
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no