[SPARK-45109][SQL][CONNECT][FOLLOWUP] Fix log function in Connect#42869
Closed
peter-toth wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-45109][SQL][CONNECT][FOLLOWUP] Fix log function in Connect#42869peter-toth wants to merge 1 commit intoapache:masterfrom
peter-toth wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
HyukjinKwon
approved these changes
Sep 11, 2023
peter-toth
force-pushed
the
SPARK-45109-fix-log
branch
from
cf4b489 to
e80e35f
Compare
Member
|
For some reasons, it can't find the build. The build is here: https://github.com/peter-toth/spark/actions/runs/6143939836/job/16668358616 |
Contributor
Author
Yeah I noticed that and force pushed a new commit so test are running now. |
zhengruifeng
approved these changes
Sep 11, 2023
| * @group math_funcs | ||
| * @since 3.4.0 | ||
| */ | ||
| def log(e: Column): Column = Column.fn("log", e) |
Contributor
There was a problem hiding this comment.
If we want to directly backport this fix to 3.4, I think Column.fn("ln", e) maybe better, otherwise, we may need separate PR for 3.4 since def ln was added in 3.5.
Contributor
Author
There was a problem hiding this comment.
I will open a 3.4 version later.
LuciferYang
approved these changes
Sep 11, 2023
panbingkun
approved these changes
Sep 11, 2023
peter-toth
added a commit
that referenced
this pull request
Sep 11, 2023
### What changes were proposed in this pull request? This is a follow-up PR to #42863, the 1 argument `log` function should also point to `ln`. ### Why are the changes needed? Bugfix. ### Does this PR introduce _any_ user-facing change? No, these Spark Connect functions haven't been released. ### How was this patch tested? Exsiting UTs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42869 from peter-toth/SPARK-45109-fix-log. Authored-by: Peter Toth <peter.toth@gmail.com> Signed-off-by: Peter Toth <peter.toth@gmail.com> (cherry picked from commit 6c3d9f5) Signed-off-by: Peter Toth <peter.toth@gmail.com>
Contributor
Author
|
Thanks for the review! Merged to master/3.5. |
Contributor
Author
|
3.4 PR: #42872 |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 12, 2023
### What changes were proposed in this pull request? This is a backport PR of #42869 as the 1 argument `log` function should point to `ln`. (Please note that the original #42863 doesn't need to be backported as `aes_descrypt` and `ln` is not implemented in Connect in Spark 3.4.) ### Why are the changes needed? Bugfix. ### Does this PR introduce _any_ user-facing change? No, these Spark Connect functions haven't been released. ### How was this patch tested? Exsiting UTs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42872 from peter-toth/SPARK-45109-fix-log-3.4. Authored-by: Peter Toth <peter.toth@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
### What changes were proposed in this pull request? This is a backport PR of apache#42869 as the 1 argument `log` function should point to `ln`. (Please note that the original apache#42863 doesn't need to be backported as `aes_descrypt` and `ln` is not implemented in Connect in Spark 3.4.) ### Why are the changes needed? Bugfix. ### Does this PR introduce _any_ user-facing change? No, these Spark Connect functions haven't been released. ### How was this patch tested? Exsiting UTs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#42872 from peter-toth/SPARK-45109-fix-log-3.4. Authored-by: Peter Toth <peter.toth@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up PR to #42863, the 1 argument
logfunction should also point toln.Why are the changes needed?
Bugfix.
Does this PR introduce any user-facing change?
No, these Spark Connect functions haven't been released.
How was this patch tested?
Exsiting UTs.
Was this patch authored or co-authored using generative AI tooling?
No.