[SPARK-45162][SQL] Support maps and array parameters constructed via call_function#42894
Closed
MaxGekk wants to merge 6 commits intoapache:masterfrom
Closed
[SPARK-45162][SQL] Support maps and array parameters constructed via call_function#42894MaxGekk wants to merge 6 commits intoapache:masterfrom
call_function#42894MaxGekk wants to merge 6 commits intoapache:masterfrom
Conversation
call_functioncall_function
call_functioncall_function
Member
Author
|
@cloud-fan @peter-toth Could you review this PR, please. |
cloud-fan
approved these changes
Sep 14, 2023
Member
Author
|
Merging to master. Thank you, @cloud-fan for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to move the
BindParametersrules from theSubstitutionto theResolutionbatch, and change types of theargsparameter ofNameParameterizedQueryandPosParameterizedQueryto anIterableto resolve argument expressions.Why are the changes needed?
After the PR, the parameterized
sql()allows map/array/struct constructed by functions likemap(),array(), andstruct(), but the same functions invoked viacall_functionare not supported:Does this PR introduce any user-facing change?
No, should not since it fixes an issue. Only if user code depends on the error message.
After the changes:
How was this patch tested?
By running new tests:
Was this patch authored or co-authored using generative AI tooling?
No.