[SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case#42971
Closed
amaliujia wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case#42971amaliujia wants to merge 2 commits intoapache:masterfrom
amaliujia wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
cloud-fan
reviewed
Sep 18, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Sep 19, 2023
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
Outdated
Show resolved
Hide resolved
amaliujia
force-pushed
the
improve_simplification
branch
from
e8ffd54 to
4dc5694
Compare
cloud-fan
approved these changes
Sep 20, 2023
Contributor
|
The failed streaming test is unrelated, I'm merging it to master/3.5, thanks! |
cloud-fan
pushed a commit
that referenced
this pull request
Sep 20, 2023
### What changes were proposed in this pull request? `simplifyPlanForCollectedMetrics ` still could need to handle non alias-only project case where the project contains a mixed of aliases and attributes. In such case `simplifyPlanForCollectedMetrics` should also drop the extra project for the plan check when it contains CollectedMetrics. ### Why are the changes needed? Improve `simplifyPlanForCollectedMetrics` so it handles more plan pattern. ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? UT ### Was this patch authored or co-authored using generative AI tooling? NO Closes #42971 from amaliujia/improve_simplification. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit d92d6f6) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
simplifyPlanForCollectedMetricsstill could need to handle non alias-only project case where the project contains a mixed of aliases and attributes. In such casesimplifyPlanForCollectedMetricsshould also drop the extra project for the plan check when it contains CollectedMetrics.Why are the changes needed?
Improve
simplifyPlanForCollectedMetricsso it handles more plan pattern.Does this PR introduce any user-facing change?
NO
How was this patch tested?
UT
Was this patch authored or co-authored using generative AI tooling?
NO