Skip to content

[SPARK-45247][BUILD][PYTHON][PS] Upgrade Pandas to 2.1.1#43025

Closed
itholic wants to merge 4 commits intoapache:masterfrom
itholic:pandas_2.1.1
Closed

[SPARK-45247][BUILD][PYTHON][PS] Upgrade Pandas to 2.1.1#43025
itholic wants to merge 4 commits intoapache:masterfrom
itholic:pandas_2.1.1

Conversation

@itholic
Copy link
Contributor

@itholic itholic commented Sep 21, 2023

What changes were proposed in this pull request?

This PR proposes to upgrade Pandas to 2.1.1.

See https://pandas.pydata.org/docs/dev/whatsnew/v2.1.1.html for detail

Why are the changes needed?

Pandas 2.1.1 is released, and we should support the latest Pandas.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

The existing CI should pass

Was this patch authored or co-authored using generative AI tooling?

No.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it seems that a regression again.

pyspark.errors.exceptions.base.PySparkAssertionError: [DIFFERENT_PANDAS_DATAFRAME] DataFrames are not almost equal:
Left:
    ba   cb   db
aa              
aa   1  1.0  1.0
ab   4  4.0  NaN
ba      int64
cb    float64
db    float64
dtype: object
Right:
    ba   cb   db
aa   1  1.0  1.0
ab   4  4.0  NaN
ba      int64
cb    float64
db    float64
dtype: object

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs)

@dongjoon-hyun
Copy link
Member

Merged to master for Apache Spark 4.0.0.

HyukjinKwon pushed a commit that referenced this pull request Sep 25, 2023
…ts.test_filter test

### What changes were proposed in this pull request?

This is followup PR for #43025 to cleanup the duplicated tests in the code.

### Why are the changes needed?

Cleanup

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No test needed / the existing CI should pass.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #43101 from itholic/pandas_2.1.1_followup.

Authored-by: Haejoon Lee <haejoon.lee@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@itholic itholic deleted the pandas_2.1.1 branch November 20, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments