[SPARK-45253][SQL][DOCS] Correct the group of ShiftLeft and ArraySize#43033
Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-45253][SQL][DOCS] Correct the group of ShiftLeft and ArraySize#43033zhengruifeng wants to merge 1 commit intoapache:masterfrom
ShiftLeft and ArraySize#43033zhengruifeng wants to merge 1 commit intoapache:masterfrom
Conversation
allisonwang-db
approved these changes
Sep 21, 2023
zhengruifeng
changed the title
ShiftLeft and ArraySizeShiftLeft and ArraySize
Contributor
Author
|
also cc @cloud-fan @HyukjinKwon |
HyukjinKwon
approved these changes
Sep 22, 2023
Member
|
Merged to master. |
HyukjinKwon
reviewed
Sep 22, 2023
| """, | ||
| since = "1.5.0", | ||
| group = "math_funcs") | ||
| group = "bitwise_funcs") |
Member
There was a problem hiding this comment.
Actually we'll need to update Scaladoc, and Python docs too. functions.scala and funcions.py and functions.R
Contributor
Author
There was a problem hiding this comment.
will do for python functions, in a separate PR
HyukjinKwon
reviewed
Sep 22, 2023
| """, | ||
| since = "3.3.0", | ||
| group = "collection_funcs") | ||
| group = "array_funcs") |
Contributor
Author
There was a problem hiding this comment.
in python, there are many functions in the incorrect groups
I will resolve it in a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Correct the group of
ShiftLeftandArraySizeWhy are the changes needed?
ShiftLeftshould be in the same group ofShiftRightandShiftRightUnsigned;ArraySizeshould be in the same group ofArrayMax,ArrayCompact, etc.Does this PR introduce any user-facing change?
yes
the two functions will be shown in correct category in https://spark.apache.org/docs/latest/sql-ref-functions.html
How was this patch tested?
manually check
Was this patch authored or co-authored using generative AI tooling?
no