-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-30848][SQL] Remove productHash from TreeNode #43161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @HyukjinKwon FYI |
|
@panbingkun Could you resolve the conflict? |
@LuciferYang Done. |
beliefer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
| // Copied from Scala 2.13.1 | ||
| // github.com/scala/scala/blob/v2.13.1/src/library/scala/util/hashing/MurmurHash3.scala#L56-L73 | ||
| // to prevent the issue https://github.com/scala/bug/issues/10495 | ||
| // TODO(SPARK-30848): Remove this once we drop Scala 2.12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use https://issues.apache.org/jira/browse/SPARK-30848 JIRA :-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was looking for this PR to learn about history. Thank you for the good record at that time! haha
LuciferYang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
What changes were proposed in this pull request?
The pr aims to replace
TreeNode.productHashwithMurmurHash3.productHash.Why are the changes needed?
1.Spark 4.0 no longer supports Scala 2.12.
2.Using MurmurHash3's class method
productHashto reduce code redundancy.https://github.com/scala/scala/blob/v2.13.11/src/library/scala/util/hashing/MurmurHash3.scala#L343
https://github.com/scala/scala/blob/v2.13.11/src/library/scala/util/hashing/MurmurHash3.scala#L64-L81
Does this PR introduce any user-facing change?
No.
How was this patch tested?
1.Pass GA.
2.Manually test:
Was this patch authored or co-authored using generative AI tooling?
No.