[SPARK-45369][SQL] Push down limit through generate#43167
Closed
wangyum wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-45369][SQL] Push down limit through generate#43167wangyum wants to merge 2 commits intoapache:masterfrom
wangyum wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
cc @cloud-fan |
beliefer
reviewed
Oct 7, 2023
Contributor
beliefer
left a comment
beliefer
left a comment
There was a problem hiding this comment.
It seems that we can continue push down the Limit beneath the Join.
|
|
||
| /** | ||
| * Pushes down [[LocalLimit]] beneath UNION ALL, OFFSET and joins. | ||
| * Pushes down [[LocalLimit]] beneath UNION ALL, OFFSET, joins, Generate and Python UDFs. |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR enhances
LimitPushDownto push down limit throughGenerateif it's outer is true. For example:Why are the changes needed?
Improve query performance. Especially push down limit through generate and join.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test and benchmark test.
Was this patch authored or co-authored using generative AI tooling?
No.