[SPARK-45423][SQL] Lower ParquetWriteSupport log level to debug#43230
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-45423][SQL] Lower ParquetWriteSupport log level to debug#43230dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
ParquetWriteSupport log level to debug#43230dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Could you review this PR, @viirya ? |
viirya
approved these changes
Oct 5, 2023
Member
Author
|
Thank you always, @viirya ! |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
Oct 7, 2023
### What changes were proposed in this pull request?
This PR aims to lower `ParquetWriteSupport` log level from INFO to DEBUG
### Why are the changes needed?
Currently, `ParquetWriteSupport` is too verbose at INFO level because it dumps the Parquet file schema per file. Since this is the only log in `ParquetWriteSupport`, the users can see this via a proper `log4j2.properties` setting when they want to debug jobs.
```
23/10/05 16:29:43 INFO ParquetOutputFormat: ParquetRecordWriter [block size: 134217728b, row group padding size: 8388608b, validating: false]
23/10/05 16:29:43 INFO ParquetWriteSupport: Initialized Parquet WriteSupport with Catalyst schema:
{
"type" : "struct",
"fields" : [ {
"name" : "id",
"type" : "long",
"nullable" : false,
"metadata" : { }
} ]
}
and corresponding Parquet message type:
message spark_schema {
required int64 id;
}
23/10/05 16:29:43 INFO MagicCommitTracker: ...
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes apache#43230 from dongjoon-hyun/SPARK-45423.
Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
### What changes were proposed in this pull request?
This PR aims to lower `ParquetWriteSupport` log level from INFO to DEBUG
### Why are the changes needed?
Currently, `ParquetWriteSupport` is too verbose at INFO level because it dumps the Parquet file schema per file. Since this is the only log in `ParquetWriteSupport`, the users can see this via a proper `log4j2.properties` setting when they want to debug jobs.
```
23/10/05 16:29:43 INFO ParquetOutputFormat: ParquetRecordWriter [block size: 134217728b, row group padding size: 8388608b, validating: false]
23/10/05 16:29:43 INFO ParquetWriteSupport: Initialized Parquet WriteSupport with Catalyst schema:
{
"type" : "struct",
"fields" : [ {
"name" : "id",
"type" : "long",
"nullable" : false,
"metadata" : { }
} ]
}
and corresponding Parquet message type:
message spark_schema {
required int64 id;
}
23/10/05 16:29:43 INFO MagicCommitTracker: ...
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes apache#43230 from dongjoon-hyun/SPARK-45423.
Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to lower
ParquetWriteSupportlog level from INFO to DEBUGWhy are the changes needed?
Currently,
ParquetWriteSupportis too verbose at INFO level because it dumps the Parquet file schema per file. Since this is the only log inParquetWriteSupport, the users can see this via a properlog4j2.propertiessetting when they want to debug jobs.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual tests.
Was this patch authored or co-authored using generative AI tooling?
No.