[SPARK-45436][PYTHON][CONNECT] DataFrame methods check same session#43248
Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-45436][PYTHON][CONNECT] DataFrame methods check same session#43248zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Conversation
zhengruifeng
force-pushed
the
py_hide_checksamesession
branch
from
87329b4 to
57b96f5
Compare
zhengruifeng
force-pushed
the
py_hide_checksamesession
branch
from
57b96f5 to
91c5fb8
Compare
beliefer
approved these changes
Oct 7, 2023
dongjoon-hyun
approved these changes
Oct 7, 2023
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @zhengruifeng and @beliefer .
Merged to master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, rename the helper function to hide from auto-completion
2, check same session for methods which deal with multiple dataframes
Why are the changes needed?
we need to make sure same session is used when process multiple dataframes
Does this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no