[SPARK-45448][PYTHON] Fix imports according to PEP8: pyspark.testing, pyspark.mllib, pyspark.resource and pyspark.streaming#43256
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
…k.resource and pyspark.streaming
Member
Author
|
cc @zhengruifeng @WeichenXu123 Fyi |
dongjoon-hyun
approved these changes
Oct 7, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @HyukjinKwon .
The pyspark-connect module failure is irrelevant to this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to fix imports according to PEP8 in
pyspark.testing,pyspark.mllib,pyspark.resourceandpyspark.streaming, see https://peps.python.org/pep-0008/#imports.Why are the changes needed?
I have not been fixing them as they are too minor. However, this practice is being propagated across the whole PySpark packages, and I think we should fix them all so other users do not follow the non-standard practice.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing linters and tests should cover.
Was this patch authored or co-authored using generative AI tooling?
No.