Skip to content

Conversation

@JoshRosen
Copy link
Contributor

This patch enables UISeleniumSuite, a set of tests for the Spark application web UI. These tests were previously disabled because they were slow, but I think we now have sufficient test time budget that the benefit of enabling them outweighs the time costs.

@JoshRosen
Copy link
Contributor Author

Unfortunately, these tests dump a bunch of WARN noise into unit-tests.log:

15/02/03 01:51:04.047 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS error: 'http://localhost:56072/static/bootstrap.min.css' [874:7581] Error in media list. (Invalid token "(". Was expecting one of: <S>, <IDENT>.)
15/02/03 01:51:04.052 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS error: 'http://localhost:56072/static/bootstrap.min.css' [874:13080] Error in media list. (Invalid token "(". Was expecting one of: <S>, <IDENT>.)
15/02/03 01:51:04.053 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS error: 'http://localhost:56072/static/bootstrap.min.css' [874:15990] Error in media list. (Invalid token "(". Was expecting one of: <S>, <IDENT>.)
15/02/03 01:51:04.059 pool-1-thread-1-ScalaTest-running-UISeleniumSuite WARN DefaultCssErrorHandler: CSS error: 'http://localhost:56072/static/webui.css' [73:17] Error in style rule. (Invalid token ":". Was expecting one of: <EOF>, <S>, <NUMBER>, "inherit", <IDENT>, <STRING>, <PLUS>, <COMMA>, <HASH>, <IMPORTANT_SYM>, <EMS>, <EXS>, <LENGTH_PX>, <LENGTH_CM>, <LENGTH_MM>, <LENGTH_IN>, <LENGTH_PT>, <LENGTH_PC>, <ANGLE_DEG>, <ANGLE_RAD>, <ANGLE_GRAD>, <TIME_MS>, <TIME_S>, <FREQ_HZ>, <FREQ_KHZ>, <PERCENTAGE>, <DIMENSION>, <URI>, <FUNCTION>, "}", ";", "/", "-".)
[...]

@JoshRosen
Copy link
Contributor Author

Fortunately, nothing was broken; the test failures here were due to either legitimate changes to the UI display (such as hiding empty tables), or untested refactorings in this file (e.g. replacing taskAttemptId with taskNumber in a case where doing so was incorrect).

@SparkQA
Copy link

SparkQA commented Feb 3, 2015

Test build #26650 has started for PR 4334 at commit 71efc72.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 3, 2015

Test build #26650 has finished for PR 4334 at commit 71efc72.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26650/
Test PASSed.

@JoshRosen
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Feb 4, 2015

Test build #26760 has started for PR 4334 at commit 71efc72.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 4, 2015

Test build #26760 has finished for PR 4334 at commit 71efc72.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26760/
Test PASSed.

@JoshRosen
Copy link
Contributor Author

This entire suite adds about 10 seconds to the total test time, which doesn't seem too bad to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to call quit() on this WebDriver in order to avoid leaking resources. I'll change this to use BeforeAndAfterAll.

@SparkQA
Copy link

SparkQA commented Feb 5, 2015

Test build #26850 has started for PR 4334 at commit 4ab9477.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 5, 2015

Test build #26850 has finished for PR 4334 at commit 4ab9477.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class UISeleniumSuite extends FunSuite with WebBrowser with Matchers with BeforeAndAfterAll

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26850/
Test PASSed.

@pwendell
Copy link
Contributor

pwendell commented Feb 5, 2015

LGTM - let's merge this and if we find it's annoying or flaky we can rip it out. Overall thought we should keep the number of these integration-style tests very low.

@JoshRosen
Copy link
Contributor Author

I'm merging this into master (1.4.0) and branch-1.3 (1.3.0).

asfgit pushed a commit that referenced this pull request Feb 6, 2015
This patch enables UISeleniumSuite, a set of tests for the Spark application web UI.  These tests were previously disabled because they were slow, but I think we now have sufficient test time budget that the benefit of enabling them outweighs the time costs.

Author: Josh Rosen <joshrosen@databricks.com>

Closes #4334 from JoshRosen/enable-uiseleniumsuite and squashes the following commits:

4ab9477 [Josh Rosen] Use BeforeAndAfterAll to cleanup WebDriver
71efc72 [Josh Rosen] Update broken UISeleniumSuite tests; use random port #.
a5ab595 [Josh Rosen] Enable UISeleniumSuite tests.

(cherry picked from commit 0d74bd7)
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
@asfgit asfgit closed this in 0d74bd7 Feb 6, 2015
@JoshRosen JoshRosen deleted the enable-uiseleniumsuite branch May 26, 2015 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants