-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-5555] Enable UISeleniumSuite tests #4334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Unfortunately, these tests dump a bunch of WARN noise into |
|
Fortunately, nothing was broken; the test failures here were due to either legitimate changes to the UI display (such as hiding empty tables), or untested refactorings in this file (e.g. replacing taskAttemptId with taskNumber in a case where doing so was incorrect). |
|
Test build #26650 has started for PR 4334 at commit
|
|
Test build #26650 has finished for PR 4334 at commit
|
|
Test PASSed. |
|
Jenkins, retest this please. |
|
Test build #26760 has started for PR 4334 at commit
|
|
Test build #26760 has finished for PR 4334 at commit
|
|
Test PASSed. |
|
This entire suite adds about 10 seconds to the total test time, which doesn't seem too bad to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to call quit() on this WebDriver in order to avoid leaking resources. I'll change this to use BeforeAndAfterAll.
|
Test build #26850 has started for PR 4334 at commit
|
|
Test build #26850 has finished for PR 4334 at commit
|
|
Test PASSed. |
|
LGTM - let's merge this and if we find it's annoying or flaky we can rip it out. Overall thought we should keep the number of these integration-style tests very low. |
|
I'm merging this into |
This patch enables UISeleniumSuite, a set of tests for the Spark application web UI. These tests were previously disabled because they were slow, but I think we now have sufficient test time budget that the benefit of enabling them outweighs the time costs. Author: Josh Rosen <joshrosen@databricks.com> Closes #4334 from JoshRosen/enable-uiseleniumsuite and squashes the following commits: 4ab9477 [Josh Rosen] Use BeforeAndAfterAll to cleanup WebDriver 71efc72 [Josh Rosen] Update broken UISeleniumSuite tests; use random port #. a5ab595 [Josh Rosen] Enable UISeleniumSuite tests. (cherry picked from commit 0d74bd7) Signed-off-by: Josh Rosen <joshrosen@databricks.com>
This patch enables UISeleniumSuite, a set of tests for the Spark application web UI. These tests were previously disabled because they were slow, but I think we now have sufficient test time budget that the benefit of enabling them outweighs the time costs.