[SPARK-45521][ML] Avoid re-computation of nnz in VectorAssembler#43353
Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-45521][ML] Avoid re-computation of nnz in VectorAssembler#43353zhengruifeng wants to merge 1 commit intoapache:masterfrom
VectorAssembler#43353zhengruifeng wants to merge 1 commit intoapache:masterfrom
Conversation
srowen
approved these changes
Oct 12, 2023
HyukjinKwon
approved these changes
Oct 12, 2023
Contributor
Author
|
thanks, merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, add a new private
compressedmethod with givennnz, since we can know it sometime;2, minor change
Array.range(0, length)->Iterator.range(0, length)to avoid array creation;Why are the changes needed?
in
VectorAssembler, thennzif already known before vector construction, the scan to compute nnz can be skipped;Does this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no