Skip to content

Conversation

@chenghao-intel
Copy link
Contributor

No description provided.

@SparkQA
Copy link

SparkQA commented Feb 3, 2015

Test build #26655 has started for PR 4339 at commit f63614b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 3, 2015

Test build #26655 has finished for PR 4339 at commit f63614b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26655/
Test PASSed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put the real types here instead? (i.e. sortCols: String*) as the flow here is super confusing. Also I'd have most versions call sort(sortCol: String, sortCols: String*), where the actual work is done.

@rxin
Copy link
Contributor

rxin commented Feb 3, 2015

Hey @chenghao-intel thanks for doing this. I'm making changes to this file right now so I will roll your change in.

@chenghao-intel
Copy link
Contributor Author

OK, I am closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants