Skip to content

[MINOR][INFRA] Skip if JIRA ID is an empty string#43417

Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon:minor-merge-script
Closed

[MINOR][INFRA] Skip if JIRA ID is an empty string#43417
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon:minor-merge-script

Conversation

@HyukjinKwon
Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR skips when an empty string is provided as a JIRA ID.

Why are the changes needed?

When you merge a minor PR that does not have a JIRA ID, and you say y to update associated JIRA, you face an error as below:

...
Would you like to update an associated JIRA? (y/n): y
Enter a JIRA id []:
ASF JIRA could not find
JiraError HTTP 405 url: https://issues.apache.org/jira/rest/api/2/issue/

	response headers = {'Date': 'Wed, 18 Oct 2023 02:44:24 GMT', 'Server': 'Apache', 'X-AREQUESTID': '164x103019855x17', 'X-ASESSIONID': '1bxvboa', 'Referrer-Policy': 'strict-origin-when-cross-origin', 'X-XSS-Protection': '1; mode=block', 'X-Content-Type-Options': 'nosniff', 'X-Frame-Options': 'SAMEORIGIN', 'Content-Security-Policy': "frame-ancestors 'self'", 'Strict-Transport-Security': 'max-age=31536000', 'X-Seraph-LoginReason': 'OK', 'X-AUSERNAME': 'gurwls223', 'Allow': 'POST,OPTIONS', 'Content-Type': 'text/html;charset=UTF-8', 'Content-Length': '0', 'Via': '1.1 jira2-he-de.apache.org', 'Keep-Alive': 'timeout=15, max=100', 'Connection': 'Keep-Alive'}
	response text =
...

After this PR, it doesn't fail but shows a warning JIRA ID not found, skipping.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

I am going to test this change against this PR.

Was this patch authored or co-authored using generative AI tooling?

No.

Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun
Copy link
Copy Markdown
Member

I used this script to merge this PR. Thank you, @HyukjinKwon ! This has been really annoying to me too. 😄

...
Would you like to update an associated JIRA? (y/n): y
Enter a JIRA id []:
JIRA ID not found, skipping.

Copy link
Copy Markdown
Contributor

@beliefer beliefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM later.

@HyukjinKwon HyukjinKwon deleted the minor-merge-script branch January 15, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants