[SPARK-45622][BUILD] java -target should use java.version instead of 17#43476
Closed
warrenzhu25 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-45622][BUILD] java -target should use java.version instead of 17#43476warrenzhu25 wants to merge 1 commit intoapache:masterfrom
warrenzhu25 wants to merge 1 commit intoapache:masterfrom
Conversation
LuciferYang
requested changes
Oct 22, 2023
Contributor
LuciferYang
left a comment
LuciferYang
left a comment
There was a problem hiding this comment.
No, Spark 4.0 needs to support building and testing with Java 17/21, but the build target needs to be fixed to 17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
java -target should use java.version instead of 17
Why are the changes needed?
java -target should use java.version instead of 17
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually tested
Was this patch authored or co-authored using generative AI tooling?
No