[SPARK-44405][SQL][TESTS] Reduce code duplication in group-based DELETE and MERGE tests#43511
Closed
zhaomin1423 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-44405][SQL][TESTS] Reduce code duplication in group-based DELETE and MERGE tests#43511zhaomin1423 wants to merge 1 commit intoapache:masterfrom
zhaomin1423 wants to merge 1 commit intoapache:masterfrom
Conversation
HyukjinKwon
changed the title
HyukjinKwon
reviewed
Oct 26, 2023
| test("delete runtime group filtering (AQE disabled)") { | ||
| withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "false") { | ||
| checkDeleteRuntimeGroupFiltering() | ||
| test("delete runtime group filtering") { |
Member
There was a problem hiding this comment.
When the test fails, we won't know if AQE or DPP is enabled or disabled?
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reduce code duplication in group-based DELETE and MERGE tests
Why are the changes needed?
There are a few reduncant mothods, merge them to reduce code duplication
Does this PR introduce any user-facing change?
No
How was this patch tested?
pass actions
Was this patch authored or co-authored using generative AI tooling?
No