Skip to content

Comments

[SPARK-45669][CORE] Ensure the continuity of rolling log index#43534

Closed
shuyouZZ wants to merge 2 commits intoapache:masterfrom
shuyouZZ:SPARK-45669
Closed

[SPARK-45669][CORE] Ensure the continuity of rolling log index#43534
shuyouZZ wants to merge 2 commits intoapache:masterfrom
shuyouZZ:SPARK-45669

Conversation

@shuyouZZ
Copy link
Contributor

What changes were proposed in this pull request?

Ensure the continuity of rolling log index.

Why are the changes needed?

Current the log file index will increment before running initLogFile(). When running rollEventlogFile(), the index will increment first, then create new log file to init event log writer.

If the log file creation fails, initLogFile() will throw an exception and stop running the method. The log file index will still increment next time rollEventLogFile() is called,
which will cause the file index to become discontinuous. EventLogFileReader can not read the event log files normally.

Therefore, we need to update the logic here to ensure the continuity of rolling log index.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing unit test

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the CORE label Oct 26, 2023
@shuyouZZ shuyouZZ closed this Oct 26, 2023
@shuyouZZ shuyouZZ reopened this Oct 26, 2023
@AngersZhuuuu
Copy link
Contributor

ping @dongjoon-hyun @srowen @cloud-fan Could you take a review about this history server issue?

@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Feb 15, 2024
@github-actions github-actions bot closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants