[SPARK-45669][CORE] Ensure the continuity of rolling log index#43534
Closed
shuyouZZ wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-45669][CORE] Ensure the continuity of rolling log index#43534shuyouZZ wants to merge 2 commits intoapache:masterfrom
shuyouZZ wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
ping @dongjoon-hyun @srowen @cloud-fan Could you take a review about this history server issue? |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ensure the continuity of rolling log index.
Why are the changes needed?
Current the log file index will increment before running
initLogFile(). When runningrollEventlogFile(), the index will increment first, then create new log file to init event log writer.If the log file creation fails,
initLogFile()will throw an exception and stop running the method. The log file index will still increment next timerollEventLogFile()is called,which will cause the file index to become discontinuous. EventLogFileReader can not read the event log files normally.
Therefore, we need to update the logic here to ensure the continuity of rolling log index.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit test
Was this patch authored or co-authored using generative AI tooling?
No