Skip to content

[SPARK-45709][BUILD] Deploy packages when all packages are built#43561

Closed
EnricoMi wants to merge 1 commit intoapache:masterfrom
G-Research:publish-snapshot-deploy-at-end
Closed

[SPARK-45709][BUILD] Deploy packages when all packages are built#43561
EnricoMi wants to merge 1 commit intoapache:masterfrom
G-Research:publish-snapshot-deploy-at-end

Conversation

@EnricoMi
Copy link
Contributor

What changes were proposed in this pull request?

Packages are deployed after all packages have been built. Currently, individual packages are deployed once they are built.

Why are the changes needed?

When some package fails to build (SPARK_45651), earlier packages have been published already, leading to an inconsistent set of latest snapshots, which might cause ClassNotFoundExceptions like in #43102 (comment). Packages should only be published once all have been built.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Locally: ./build/mvn deploy builds all packages before it attempts to upload any.

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the BUILD label Oct 27, 2023
@EnricoMi
Copy link
Contributor Author

CC @HyukjinKwon @LuciferYang

@EnricoMi
Copy link
Contributor Author

EnricoMi commented Nov 6, 2023

@LuciferYang @HyukjinKwon the publish snapshot workflow keeps failing due to HTTP errors, which still causes inconsistent snapshot packages: https://github.com/apache/spark/actions/workflows/publish_snapshot.yml

Please consider this fix.

@EnricoMi
Copy link
Contributor Author

@EnricoMi EnricoMi force-pushed the publish-snapshot-deploy-at-end branch from e9b8cf8 to 12554e4 Compare January 10, 2024 19:47
@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Apr 20, 2024
@github-actions github-actions bot closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant