Skip to content

[SPARK-45697][BUILD] Fix Unicode escapes in triple quoted strings are deprecated #43603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panbingkun wants to merge 11 commits into from
Closed

[SPARK-45697][BUILD] Fix Unicode escapes in triple quoted strings are deprecated #43603

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d5d5200
[SPARK-45697][BUILD] Fix `Unicode escapes in triple quoted strings ar…
panbingkun Oct 31, 2023
005a175
fix pom.xml
panbingkun Oct 31, 2023
c13ef9e
[SPARK-45697][BUILD] Fix `Unicode escapes in triple quoted strings ar…
panbingkun Nov 1, 2023
3a9d80f
[SPARK-45697][BUILD] Fix Unicode escapes in triple quoted strings are…
panbingkun Nov 6, 2023
8abeac5
Merge branch 'master' into SPARK-45697
panbingkun Nov 6, 2023
2a99240
Merge branch 'master' into SPARK-45697
panbingkun Nov 17, 2023
5e84eaf
[SPARK-45697][BUILD] Fix Unicode escapes in triple quoted strings are…
panbingkun Nov 17, 2023
2832827
Merge branch 'master' into SPARK-45697
panbingkun Nov 17, 2023
6956df8
Merge branch 'master' into SPARK-45697
panbingkun Nov 17, 2023
3586bc1
[SPARK-45697][BUILD] Fix Unicode escapes in triple quoted strings are…
panbingkun Nov 21, 2023
c647f64
Merge branch 'master' into SPARK-45697
panbingkun Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

package org.apache.spark.sql.catalyst.parser

import scala.annotation.nowarn

import org.apache.spark.SparkThrowable
import org.apache.spark.sql.catalyst.{FunctionIdentifier, TableIdentifier}
import org.apache.spark.sql.catalyst.analysis.{AnalysisTest, NamedParameter, PosParameter, RelationTimeTravel, UnresolvedAlias, UnresolvedAttribute, UnresolvedFunction, UnresolvedGenerator, UnresolvedInlineTable, UnresolvedRelation, UnresolvedStar, UnresolvedSubqueryColumnAliases, UnresolvedTableValuedFunction, UnresolvedTVFAliases}
Expand Down Expand Up @@ -1678,7 +1680,8 @@ class PlanParserSuite extends AnalysisTest {
List.empty, List.empty, None, None, false)))

// verify with ROW FORMAT DELIMETED
assertEqual(
@nowarn("cat=deprecation")
Copy link
Contributor

@LuciferYang LuciferYang Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine-grained suppressing this case with @nowarn if fine to me

val sqlWithRowFormatDelimiters: String =
"""
|SELECT TRANSFORM(a, b, c)
| ROW FORMAT DELIMITED
Expand All @@ -1695,7 +1698,9 @@ class PlanParserSuite extends AnalysisTest {
| LINES TERMINATED BY '\n'
| NULL DEFINED AS 'NULL'
|FROM testData
""".stripMargin,
""".stripMargin
assertEqual(
sqlWithRowFormatDelimiters,
ScriptTransformation(
"cat",
Seq(AttributeReference("a", StringType)(),
Expand Down