[SPARK-43380][SQL][Follow-up] Fix slowdown in Avro read#43606
Closed
zeruibao wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-43380][SQL][Follow-up] Fix slowdown in Avro read#43606zeruibao wants to merge 3 commits intoapache:masterfrom
zeruibao wants to merge 3 commits intoapache:masterfrom
Conversation
gengliangwang
approved these changes
Oct 31, 2023
Contributor
Author
|
Hi @gengliangwang and @dongjoon-hyun, all avro related tests have passed. Should be good to merge now haha. |
HyukjinKwon
approved these changes
Oct 31, 2023
Member
|
Thanks,merging to master/branch-3.5 |
gengliangwang
pushed a commit
that referenced
this pull request
Oct 31, 2023
### What changes were proposed in this pull request? Fix slowdown in Avro read. There is a #42503 that causes the performance regression. It seems that `SQLConf.get.getConf(confKey)` is very costly. Move it out of `newWriter` function. ### Why are the changes needed? Need to fix the performance regression of Avro read. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UT test ### Was this patch authored or co-authored using generative AI tooling? No Closes #43606 from zeruibao/SPARK-43380-FIX-SLOWDOWN. Authored-by: zeruibao <zerui.bao@databricks.com> Signed-off-by: Gengliang Wang <gengliang@apache.org> (cherry picked from commit 45f73bc) Signed-off-by: Gengliang Wang <gengliang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix slowdown in Avro read. There is a #42503 that causes the performance regression. It seems that
SQLConf.get.getConf(confKey)is very costly. Move it out ofnewWriterfunction.Why are the changes needed?
Need to fix the performance regression of Avro read.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT test
Was this patch authored or co-authored using generative AI tooling?
No