[SPARK-45757][ML] Avoid re-computation of NNZ in Binarizer#43619
Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-45757][ML] Avoid re-computation of NNZ in Binarizer#43619zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Conversation
50e28fd to
418ef3d
Compare
srowen
approved these changes
Nov 2, 2023
Member
|
Merged to master for Apache Spark 4.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, compress vectors with given nnz in Binarizer;
2, rename internal function
def compressed(nnz: Int): Vectorto avoid ambiguous reference issue (vec.compressed.apply(nnz)) when there is no type hintWhy are the changes needed?
nnzis known before compressionDoes this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no