Skip to content

Comments

[SPARK-45837][CONNECT] Improve logging information in handling retries#43719

Closed
cdkrot wants to merge 2 commits intoapache:masterfrom
cdkrot:SPARK-45837
Closed

[SPARK-45837][CONNECT] Improve logging information in handling retries#43719
cdkrot wants to merge 2 commits intoapache:masterfrom
cdkrot:SPARK-45837

Conversation

@cdkrot
Copy link
Contributor

@cdkrot cdkrot commented Nov 8, 2023

What changes were proposed in this pull request?

Add suppressed exception when handling retries

Why are the changes needed?

Improves user and debugging experience by showing underlying error.

Does this PR introduce any user-facing change?

Better exceptions.

How was this patch tested?

Hand testing

Was this patch authored or co-authored using generative AI tooling?

NA

@cdkrot
Copy link
Contributor Author

cdkrot commented Nov 8, 2023

cc @juliuszsompolski

Copy link
Contributor

@hvanhovell hvanhovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@juliuszsompolski juliuszsompolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-45837][CONNECT][SCALA] Improve logging information in handling retries [SPARK-45837][CONNECT] Improve logging information in handling retries Nov 8, 2023
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs)

@dongjoon-hyun
Copy link
Member

Could you re-trigger CI, @cdkrot ?

@cdkrot
Copy link
Contributor Author

cdkrot commented Nov 9, 2023

Had retriggered

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants