[MINOR] Fix some typo#43724
Closed
panbingkun wants to merge 7 commits into
Closed
Conversation
HyukjinKwon
reviewed
Nov 10, 2023
|
|
||
| /** | ||
| * Convert wildchars and escape sequence from JDBC format to datanucleous/regex | ||
| * Convert wildcards and escape sequence from JDBC format to datanucleus/regex |
Member
There was a problem hiding this comment.
I think this is from Hive. Let's just leave them.
Contributor
Author
There was a problem hiding this comment.
Okay.
I am still checking if there are other similar typo and submitting them together.
HyukjinKwon
reviewed
Nov 14, 2023
|
|
||
| 1. When Spark is running in a cloud infrastructure, the credentials are usually automatically set up. | ||
| 1. `spark-submit` is able to read the `AWS_ENDPOINT_URL`, `AWS_ACCESS_KEY_ID`, `AWS_SECRET_ACCESS_KEY` | ||
| 2. `spark-submit` is able to read the `AWS_ENDPOINT_URL`, `AWS_ACCESS_KEY_ID`, `AWS_SECRET_ACCESS_KEY` |
Member
There was a problem hiding this comment.
1. 1. 1. is fine. we don;t need to manually change the numbering
Contributor
Author
There was a problem hiding this comment.
Okay, Let me revert it.
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to fix some typo.
Why are the changes needed?
Fix some typo.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.