Skip to content

[SPARK-45848][BUILD] Make spark-version-info.properties generated by spark-build-info.ps1 include docroot#43726

Closed
LuciferYang wants to merge 2 commits intoapache:masterfrom
LuciferYang:SPARK-45848
Closed

[SPARK-45848][BUILD] Make spark-version-info.properties generated by spark-build-info.ps1 include docroot#43726
LuciferYang wants to merge 2 commits intoapache:masterfrom
LuciferYang:SPARK-45848

Conversation

@LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Nov 9, 2023

What changes were proposed in this pull request?

The spark-version-info.properties generated by spark-build-info include docroot=https://spark.apache.org/docs/latest, this pr make spark-version-info.properties generated by spark-build-info.ps1 also include docroot part.

Why are the changes needed?

Keep the items generated by spark-build-info and spark-build-info.ps1 consistent

Does this PR introduce any user-facing change?

No

How was this patch tested?

Manual verification with this pr:

  • spark-version-info.properties generated by spark-build-info
version=4.0.0-SNAPSHOT
user=yangjie01
revision=d92f634bdaf8d040b7c7a5ca675db3cb265486b5
branch=SPARK-45848
date=2023-11-09T06:21:05Z
url=git@github.com:LuciferYang/spark.git
docroot=https://spark.apache.org/docs/latest
  • spark-version-info.properties generated by spark-build-info.ps1
version=4.0.0-SNAPSHOT
user=yangjie01
revision=d92f634bdaf8d040b7c7a5ca675db3cb265486b5
branch=SPARK-45848
date=2023-11-09T06:22:25Z
url=git@github.com:LuciferYang/spark.git,
docroot=https://spark.apache.org/docs/latest

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the BUILD label Nov 9, 2023
@LuciferYang
Copy link
Contributor Author

cc @wangyum FYI

Step to check with ps on mac:

  1. install ps: https://github.com/powershell/powershell#get-powershell
  2. run export USERNAME=${userName}
  3. run /usr/local/bin/pwsh -File build/spark-build-info.ps1 ${basedir} ${spark-version}
  4. run cat ${basedir}/spark-version-info.properties to check result

@LuciferYang LuciferYang changed the title [SPARK-45848] Make spark-version-info.properties generated by spark-build-info.ps1 include docroot [SPARK-45848][BUILD] Make spark-version-info.properties generated by spark-build-info.ps1 include docroot Nov 9, 2023
Comment on lines +44 to +45
url=$(git config --get remote.origin.url),
docroot=https://spark.apache.org/docs/latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LuciferYang
Copy link
Contributor Author

Thanks @dongjoon-hyun and @wangyum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants