[SPARK-45848][BUILD] Make spark-version-info.properties generated by spark-build-info.ps1 include docroot#43726
Closed
LuciferYang wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-45848][BUILD] Make spark-version-info.properties generated by spark-build-info.ps1 include docroot#43726LuciferYang wants to merge 2 commits intoapache:masterfrom
spark-version-info.properties generated by spark-build-info.ps1 include docroot#43726LuciferYang wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
cc @wangyum FYI Step to check with ps on mac:
|
spark-version-info.properties generated by spark-build-info.ps1 include docrootspark-version-info.properties generated by spark-build-info.ps1 include docroot
wangyum
reviewed
Nov 9, 2023
Comment on lines
+44
to
+45
| url=$(git config --get remote.origin.url), | ||
| docroot=https://spark.apache.org/docs/latest" |
dongjoon-hyun
approved these changes
Nov 12, 2023
Contributor
Author
|
Thanks @dongjoon-hyun and @wangyum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
spark-version-info.propertiesgenerated byspark-build-infoincludedocroot=https://spark.apache.org/docs/latest, this pr makespark-version-info.propertiesgenerated byspark-build-info.ps1also includedocrootpart.Why are the changes needed?
Keep the items generated by
spark-build-infoandspark-build-info.ps1consistentDoes this PR introduce any user-facing change?
No
How was this patch tested?
Manual verification with this pr:
spark-version-info.propertiesgenerated byspark-build-infospark-version-info.propertiesgenerated byspark-build-info.ps1Was this patch authored or co-authored using generative AI tooling?
No