Skip to content

[SPARK-45562][DOCS] Regenerate docs/sql-error-conditions.md and add 42KDF to SQLSTATE table in error/README.md#43817

Closed
LuciferYang wants to merge 1 commit intoapache:masterfrom
LuciferYang:SPARK-45562-FOLLOWUP
Closed

[SPARK-45562][DOCS] Regenerate docs/sql-error-conditions.md and add 42KDF to SQLSTATE table in error/README.md#43817
LuciferYang wants to merge 1 commit intoapache:masterfrom
LuciferYang:SPARK-45562-FOLLOWUP

Conversation

@LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Nov 15, 2023

What changes were proposed in this pull request?

This pr re-generate docs/sql-error-conditions.md and add 42KDF to SQLSTATE table in error/README.md refer to https://docs.gcp.databricks.com/error-messages/sqlstates.html

image

Why are the changes needed?

Make GA pass

https://github.com/apache/spark/actions/runs/6874376893/job/18695941494

[info] - SQLSTATE invariants *** FAILED *** (30 milliseconds)
[info]   fx.apply(s) was false 42KDF (SparkThrowableSuite.scala:74)
[info]   org.scalatest.exceptions.TestFailedException:
[info]   at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info]   at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info]   at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
[info]   at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
[info]   at org.apache.spark.SparkThrowableSuite.$anonfun$checkCondition$1(SparkThrowableSuite.scala:74)
[info]   at scala.collection.immutable.List.foreach(List.scala:333)
[info]   at org.apache.spark.SparkThrowableSuite.checkCondition(SparkThrowableSuite.scala:73)
[info]   at org.apache.spark.SparkThrowableSuite.$anonfun$new$6(SparkThrowableSuite.scala:138)
[info]   at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
[info]   at org.scalatest.enablers.Timed$$anon$1.timeoutAfter(Timed.scala:127)
....
[info] - Error classes match with document *** FAILED *** (71 milliseconds)
[info]   "...gs-error-class.html)[
[info]   
[info]   ### XML_ROW_TAG_MISSING
[info]   
[info]   [SQLSTATE: 42KDF](sql-error-conditions-sqlstates.html#class-42-syntax-error-or-access-rule-violation)
[info]   
[info]   `<rowTag>` option is required for reading files in XML format.]" did not equal "...gs-error-class.html)[]" The error class document is not up to date. Please regenerate it. (SparkThrowableSuite.scala:346)
[info]   Analysis:
[info]   "...gs-error-class.html)[
[info] 
[info] ### XML_ROW_TAG_MISSING
[info] 
[info] [SQLSTATE: 42KDF](sql-error-conditions-sqlstates.html#class-42-syntax-error-or-access-rule-violation)
[info] 
[info] `<rowTag>` option is required for reading files in XML format.]" -> "...gs-error-class.html)[]"

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Pass GitHub Actions
  • Manual check build/sbt "core/testOnly *SparkThrowableSuite"

Before

[info] Run completed in 1 second, 205 milliseconds.
[info] Total number of tests run: 19
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 17, failed 2, canceled 0, ignored 0, pending 0
[info] *** 2 TESTS FAILED ***
[error] Failed tests:
[error]         org.apache.spark.SparkThrowableSuite

After

[info] Run completed in 1 second, 131 milliseconds.
[info] Total number of tests run: 19
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 19, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the DOCS label Nov 15, 2023
@LuciferYang LuciferYang changed the title [SPARK-45562][CORE][DOCS] Regenerate docs/sql-error-conditions.md and update SQLSTATE table in error/README.md [SPARK-45562][CORE][DOCS] Regenerate docs/sql-error-conditions.md and add 42KDF to SQLSTATE table in error/README.md Nov 15, 2023
@LuciferYang
Copy link
Contributor Author

cc @HyukjinKwon @beliefer @sandip-db

@LuciferYang LuciferYang changed the title [SPARK-45562][CORE][DOCS] Regenerate docs/sql-error-conditions.md and add 42KDF to SQLSTATE table in error/README.md [SPARK-45562][DOCS] Regenerate docs/sql-error-conditions.md and add 42KDF to SQLSTATE table in error/README.md Nov 15, 2023
@sandip-db
Copy link
Contributor

LGTM. @LuciferYang Thanks for the quick fix.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

Copy link
Contributor

@beliefer beliefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

late LGTM.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@LuciferYang
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants