[SPARK-45938][INFRA] Add utils to the dependencies of the core/unsafe/network_common module in module.py#43818
Closed
LuciferYang wants to merge 4 commits into
Closed
[SPARK-45938][INFRA] Add utils to the dependencies of the core/unsafe/network_common module in module.py#43818LuciferYang wants to merge 4 commits into
utils to the dependencies of the core/unsafe/network_common module in module.py#43818LuciferYang wants to merge 4 commits into
Conversation
utils to the dependency list of the core module in module.pyutils to the dependencies of the core module in module.py
LuciferYang
commented
Nov 15, 2023
| core = Module( | ||
| name="core", | ||
| dependencies=[kvstore, network_common, network_shuffle, unsafe, launcher], | ||
| dependencies=[kvstore, network_common, network_shuffle, unsafe, launcher, utils], |
Contributor
Author
There was a problem hiding this comment.
cc @zhengruifeng @HyukjinKwon , utils module is also a direct dependency of unsafe and network-common. Do we need to modify the dependencies of unsafe and network-common? Or is the current change sufficient?
Contributor
There was a problem hiding this comment.
utils module is also a direct dependency of unsafe and network-common
let's also add this dependency
LuciferYang
commented
Nov 16, 2023
| ], | ||
| ) | ||
|
|
||
| utils = Module( |
Contributor
Author
Contributor
There was a problem hiding this comment.
yeah, this is python :)
utils to the dependencies of the core module in module.pyutils to the dependencies of the core/unsafe/network_common module in module.py
zhengruifeng
approved these changes
Nov 16, 2023
Contributor
Author
|
Thanks @zhengruifeng |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes were proposed in this pull request?
This pr add
utilsto the dependencies of thecore/unsafe/network_commonmodule inmodule.pydue toutilsis direct dependency ofcore/unsafe/network_common:spark/core/pom.xml
Lines 102 to 106 in 7120e6b
spark/common/unsafe/pom.xml
Lines 44 to 48 in ef93dc2
spark/common/network-common/pom.xml
Lines 177 to 181 in ef93dc2
Why are the changes needed?
All UTs of
utilsmodule are still in thecoremodule now. This pr is used to avoid the issue of not running unit tests in thecoremodule when changing theutilsmodule.Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No