Skip to content

Comments

[SPARK-45948][K8S] Make single-pod spark jobs respect spark.app.id#43833

Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-45948
Closed

[SPARK-45948][K8S] Make single-pod spark jobs respect spark.app.id#43833
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-45948

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 16, 2023

What changes were proposed in this pull request?

This PR aims to make single-pod Spark jobs respect spark.app.id in K8s environment.

Why are the changes needed?

Since Apache Spark 3.4.0, SPARK-42190 allows users to run single-pod Spark jobs in K8s environment by utilizing LocalSchedulerBackend in the driver pod. However, LocalSchedulerBackend doesn't respect spark.app.id while KubernetesClusterSchedulerBackend does. This PR aims to improve K8s UX by reducing the behavior difference between single-pod Spark jobs and multi-pod Spark jobs in K8s environment.

Does this PR introduce any user-facing change?

Yes, but it's more consistent with the existing general K8s jobs.

How was this patch tested?

Pass the CIs with the newly added test case.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Could you review this when you have some time, please, @LuciferYang ?

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you, @yaooqinn and @LuciferYang !

@dongjoon-hyun
Copy link
Member Author

All tests passed. Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-45948 branch November 16, 2023 08:32
szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Feb 7, 2024
This PR aims to make single-pod Spark jobs respect `spark.app.id` in K8s environment.

Since Apache Spark 3.4.0, SPARK-42190 allows users to run single-pod Spark jobs in K8s environment by utilizing `LocalSchedulerBackend` in the driver pod. However, `LocalSchedulerBackend` doesn't respect `spark.app.id` while `KubernetesClusterSchedulerBackend` does. This PR aims to improve K8s UX by reducing the behavior difference between single-pod Spark jobs and multi-pod Spark jobs in K8s environment.

Yes, but it's more consistent with the existing general K8s jobs.

Pass the CIs with the newly added test case.

No.

Closes apache#43833 from dongjoon-hyun/SPARK-45948.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants