[SPARK-45948][K8S] Make single-pod spark jobs respect spark.app.id#43833
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-45948][K8S] Make single-pod spark jobs respect spark.app.id#43833dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
spark.app.id#43833dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Could you review this when you have some time, please, @LuciferYang ? |
yaooqinn
approved these changes
Nov 16, 2023
Member
Author
|
Thank you, @yaooqinn and @LuciferYang ! |
Member
Author
|
All tests passed. Merged to master. |
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Feb 7, 2024
This PR aims to make single-pod Spark jobs respect `spark.app.id` in K8s environment. Since Apache Spark 3.4.0, SPARK-42190 allows users to run single-pod Spark jobs in K8s environment by utilizing `LocalSchedulerBackend` in the driver pod. However, `LocalSchedulerBackend` doesn't respect `spark.app.id` while `KubernetesClusterSchedulerBackend` does. This PR aims to improve K8s UX by reducing the behavior difference between single-pod Spark jobs and multi-pod Spark jobs in K8s environment. Yes, but it's more consistent with the existing general K8s jobs. Pass the CIs with the newly added test case. No. Closes apache#43833 from dongjoon-hyun/SPARK-45948. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to make single-pod Spark jobs respect
spark.app.idin K8s environment.Why are the changes needed?
Since Apache Spark 3.4.0, SPARK-42190 allows users to run single-pod Spark jobs in K8s environment by utilizing
LocalSchedulerBackendin the driver pod. However,LocalSchedulerBackenddoesn't respectspark.app.idwhileKubernetesClusterSchedulerBackenddoes. This PR aims to improve K8s UX by reducing the behavior difference between single-pod Spark jobs and multi-pod Spark jobs in K8s environment.Does this PR introduce any user-facing change?
Yes, but it's more consistent with the existing general K8s jobs.
How was this patch tested?
Pass the CIs with the newly added test case.
Was this patch authored or co-authored using generative AI tooling?
No.