-
Notifications
You must be signed in to change notification settings - Fork 29k
SPARK-5613: Catch the ApplicationNotFoundException exception to avoid thread from getting killed on yarn restart. #4392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thread from getting killed on yarn restart.
|
Can one of the admins verify this patch? |
|
ok to test |
|
This change looks reasonable. LGTM once tests pass |
|
Test build #26926 has started for PR 4392 at commit
|
|
Hey @kasjain can you open this against the master branch next time? It will be easier for us to back port stuff from there |
|
Test build #26926 has finished for PR 4392 at commit
|
|
Test PASSed. |
|
Merging into 1.2 thanks. |
… thread from getting killed on yarn restart. [SPARK-5613] Added a catch block to catch the ApplicationNotFoundException. Without this catch block the thread gets killed on occurrence of this exception. This Exception occurs when yarn restarts and tries to find an application id for a spark job which got interrupted due to yarn getting stopped. See the stacktrace in the bug for more details. Author: Kashish Jain <kashish.jain@guavus.com> Closes #4392 from kasjain/branch-1.2 and squashes the following commits: 4831000 [Kashish Jain] SPARK-5613: Catch the ApplicationNotFoundException exception to avoid thread from getting killed on yarn restart.
|
Hey @kasjain this is already merged into branch 1.2. Would you mind closing this? |
|
Sure. Thanks :) From: andrewor14 <notifications@github.commailto:notifications@github.com> Hey @kasjainhttps://github.com/kasjain can you open this against the master branch next time? It will be easier for us to back port stuff from there — |
|
Thanks for closing this issue. From: andrewor14 <notifications@github.commailto:notifications@github.com> Hey @kasjainhttps://github.com/kasjain this is already merged into branch 1.2. Would you mind closing this? — |
… thread from getting killed on yarn restart. [SPARK-5613] Added a catch block to catch the ApplicationNotFoundException. Without this catch block the thread gets killed on occurrence of this exception. This Exception occurs when yarn restarts and tries to find an application id for a spark job which got interrupted due to yarn getting stopped. See the stacktrace in the bug for more details. Author: Kashish Jain <kashish.jain@guavus.com> Closes #4392 from kasjain/branch-1.2 and squashes the following commits: 4831000 [Kashish Jain] SPARK-5613: Catch the ApplicationNotFoundException exception to avoid thread from getting killed on yarn restart.
|
@andrewor14 this was never merged into branch 1.3 and I believe that caused a recent build break. So I just merged it. |
|
i think for yarn-cluster mode, we also should catch the ApplicationNotFoundException for getApplicationReport.@pwendell @andrewor14 |
|
Hi, Is this change required in yarn-cluster mode as well? Is yes, is there any already opened ticket for this? Thanks From: Lianhui Wang <notifications@github.commailto:notifications@github.com> i think for yarn-cluster mode, we also should catch the ApplicationNotFoundException.@pwendellhttps://github.com/pwendell@andrewor14https://github.com/andrewor14 — |
[SPARK-5613] Added a catch block to catch the ApplicationNotFoundException. Without this catch block the thread gets killed on occurrence of this exception. This Exception occurs when yarn restarts and tries to find an application id for a spark job which got interrupted due to yarn getting stopped.
See the stacktrace in the bug for more details.