[MINOR][TEST] Relax excludedTpcdsQueries scope in TPCDSBase#43943
Closed
viirya wants to merge 1 commit into
Closed
[MINOR][TEST] Relax excludedTpcdsQueries scope in TPCDSBase#43943viirya wants to merge 1 commit into
excludedTpcdsQueries scope in TPCDSBase#43943viirya wants to merge 1 commit into
Conversation
dongjoon-hyun
approved these changes
Nov 21, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @viirya .
Member
Author
|
Not sure why notify test workflow doesn't work. The CI run link: https://github.com/viirya/spark-1/actions/runs/6948703391 |
Member
Author
|
Thank you @dongjoon-hyun |
Member
|
TPCDS pipeline passed. Merged to master. |
Member
Author
|
Thank you again @dongjoon-hyun ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch relaxes the scope of
excludedTpcdsQueriesinTPCDSBasefromprivatetoprotected.Why are the changes needed?
When working on TPCDS related tests with
TPCDSBaseor classes implementing it, sometime we need to exclude some queries. ButexcludedTpcdsQueriesis private so it limits the extensibility.Does this PR introduce any user-facing change?
No, this is test only change.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No