Skip to content

[SPARK-46012][CORE][FOLLOWUP] Invoke fs.listStatus once and reuse the result#43944

Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-46012-2
Closed

[SPARK-46012][CORE][FOLLOWUP] Invoke fs.listStatus once and reuse the result#43944
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-46012-2

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 21, 2023

What changes were proposed in this pull request?

This PR is a follow-up of #43914 and aims to invoke fs.listStatus once and reuse the result.

Why are the changes needed?

This will prevent the increase of the number of listStatus invocation .

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs with the existing test case.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the CORE label Nov 21, 2023
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-46012][CORE][FOLLOWUP] Invoke fs.listStatus once and reuse the result [SPARK-46012][CORE][FOLLOWUP] Invoke fs.listStatus once and reuse the result Nov 21, 2023
@dongjoon-hyun
Copy link
Member Author

cc @mridulm , @HyukjinKwon , @LuciferYang

Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dongjoon-hyun

@dongjoon-hyun
Copy link
Member Author

Thank you, @yaooqinn !

dongjoon-hyun added a commit that referenced this pull request Nov 22, 2023
…he result

### What changes were proposed in this pull request?

This PR is a follow-up of #43914 and aims to invoke `fs.listStatus` once and reuse the result.

### Why are the changes needed?

This will prevent the increase of the number of `listStatus` invocation .

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs with the existing test case.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #43944 from dongjoon-hyun/SPARK-46012-2.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 6be4a03)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun added a commit that referenced this pull request Nov 22, 2023
…he result

### What changes were proposed in this pull request?

This PR is a follow-up of #43914 and aims to invoke `fs.listStatus` once and reuse the result.

### Why are the changes needed?

This will prevent the increase of the number of `listStatus` invocation .

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs with the existing test case.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #43944 from dongjoon-hyun/SPARK-46012-2.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 6be4a03)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun added a commit that referenced this pull request Nov 22, 2023
…he result

### What changes were proposed in this pull request?

This PR is a follow-up of #43914 and aims to invoke `fs.listStatus` once and reuse the result.

### Why are the changes needed?

This will prevent the increase of the number of `listStatus` invocation .

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs with the existing test case.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #43944 from dongjoon-hyun/SPARK-46012-2.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 6be4a03)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun dongjoon-hyun deleted the SPARK-46012-2 branch November 22, 2023 01:52
@dongjoon-hyun
Copy link
Member Author

Merged to master/3.5/3.4/3.3.

@LuciferYang
Copy link
Contributor

late LGTM

@mridulm
Copy link
Contributor

mridulm commented Nov 22, 2023

Thanks for fixing this @dongjoon-hyun !

szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Feb 7, 2024
…he result

### What changes were proposed in this pull request?

This PR is a follow-up of apache#43914 and aims to invoke `fs.listStatus` once and reuse the result.

### Why are the changes needed?

This will prevent the increase of the number of `listStatus` invocation .

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs with the existing test case.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#43944 from dongjoon-hyun/SPARK-46012-2.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 6be4a03)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants