[SPARK-46224][PYTHON][MLLIB][TESTS] Test string representation of TestResult (pyspark.mllib.stat.test)#44138
Closed
HyukjinKwon wants to merge 1 commit into
Closed
[SPARK-46224][PYTHON][MLLIB][TESTS] Test string representation of TestResult (pyspark.mllib.stat.test)#44138HyukjinKwon wants to merge 1 commit into
HyukjinKwon wants to merge 1 commit into
Conversation
zhengruifeng
approved these changes
Dec 4, 2023
Member
Author
|
The linter failure is by #44141. Merged to master. |
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Dec 5, 2023
…tResult (pyspark.mllib.stat.test) ### What changes were proposed in this pull request? This PR adds a test for `toString` on the model via `TestResult` within `pyspark.mllib.stat.test`. ### Why are the changes needed?  https://app.codecov.io/gh/apache/spark/blob/master/python%2Fpyspark%2Fmllib%2Fstat%2Ftest.py#L28 This is not being tested. ### Does this PR introduce _any_ user-facing change? No, test-only ### How was this patch tested? Manually ran the new unittest. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44138 from HyukjinKwon/SPARK-46041. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
…tResult (pyspark.mllib.stat.test) ### What changes were proposed in this pull request? This PR adds a test for `toString` on the model via `TestResult` within `pyspark.mllib.stat.test`. ### Why are the changes needed?  https://app.codecov.io/gh/apache/spark/blob/master/python%2Fpyspark%2Fmllib%2Fstat%2Ftest.py#L28 This is not being tested. ### Does this PR introduce _any_ user-facing change? No, test-only ### How was this patch tested? Manually ran the new unittest. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44138 from HyukjinKwon/SPARK-46041. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a test for
toStringon the model viaTestResultwithinpyspark.mllib.stat.test.Why are the changes needed?
https://app.codecov.io/gh/apache/spark/blob/master/python%2Fpyspark%2Fmllib%2Fstat%2Ftest.py#L28
This is not being tested.
Does this PR introduce any user-facing change?
No, test-only
How was this patch tested?
Manually ran the new unittest.
Was this patch authored or co-authored using generative AI tooling?
No.