Skip to content

Comments

[SPARK-46316][CORE] Enable buf-lint-action on core module#44246

Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-46316
Closed

[SPARK-46316][CORE] Enable buf-lint-action on core module#44246
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-46316

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Dec 8, 2023

What changes were proposed in this pull request?

This PR aims to enable buf-lint-action on core module.

Why are the changes needed?

To enforce the community guideline.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Screenshot 2023-12-07 at 7 40 54 PM

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

@LuciferYang
Copy link
Contributor

I thought of a question, branch-3.3 does not have this directory, will this cause the daily test to fail?

@dongjoon-hyun
Copy link
Member Author

I thought of a question, branch-3.3 does not have this directory, will this cause the daily test to fail?

No, it's skipped in branch-3.3.

Screenshot 2023-12-07 at 7 55 20 PM

@dongjoon-hyun
Copy link
Member Author

Thank you, @yaooqinn and @LuciferYang . Since the changed pipeline is already passed, I'll merge this.

@LuciferYang
Copy link
Contributor

Thanks for your answer. @dongjoon-hyun

@dongjoon-hyun
Copy link
Member Author

Oh... It seems that we didn't add this to the whitelist yet. Let me check the INFRA JIRAs.

Screenshot 2023-12-07 at 8 00 00 PM

Screenshot 2023-12-07 at 8 01 13 PM

@dongjoon-hyun
Copy link
Member Author

Ya, my bad. I must check the JIRA first. Very sorry. Let me revert this first and file a new INFRA JIRA.

https://issues.apache.org/jira/browse/INFRA-24404
(Allow to use bufbuild/buf-setup-action and bufbuild/buf-breaking-action in GitHub Actions)

@dongjoon-hyun
Copy link
Member Author

https://issues.apache.org/jira/browse/INFRA-25255 (Allow to use bufbuild/buf-lint-action in GitHub Actions) is filed .

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Dec 8, 2023

wait, we already have this: https://github.com/apache/spark/blob/master/.github/workflows/build_and_test.yml#L588-L591

or is this sth else?

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Dec 8, 2023

ohh it's litner sorry. ignore my comment above. +1 to have this!

@dongjoon-hyun
Copy link
Member Author

Thanks, @HyukjinKwon .

@dongjoon-hyun
Copy link
Member Author

ASF Infra team handled it. Let me put this back~

dongjoon-hyun added a commit that referenced this pull request Dec 8, 2023
### What changes were proposed in this pull request?

This PR aims to enable `buf-lint-action` on `core` module.

### Why are the changes needed?

To enforce the community guideline.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

![Screenshot 2023-12-07 at 7 40 54 PM](https://github.com/apache/spark/assets/9700541/7777b23f-d8be-410a-bc61-88f8b477a3b0)

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #44246 from dongjoon-hyun/SPARK-46316.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Dec 8, 2023

It's working!

Screenshot 2023-12-07 at 9 50 02 PM

@dongjoon-hyun dongjoon-hyun deleted the SPARK-46316 branch December 8, 2023 05:50
dbatomic pushed a commit to dbatomic/spark that referenced this pull request Dec 11, 2023
### What changes were proposed in this pull request?

This PR aims to enable `buf-lint-action` on `core` module.

### Why are the changes needed?

To enforce the community guideline.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

![Screenshot 2023-12-07 at 7 40 54 PM](https://github.com/apache/spark/assets/9700541/7777b23f-d8be-410a-bc61-88f8b477a3b0)

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#44246 from dongjoon-hyun/SPARK-46316.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dbatomic pushed a commit to dbatomic/spark that referenced this pull request Dec 11, 2023
### What changes were proposed in this pull request?

This PR aims to enable `buf-lint-action` on `core` module.

### Why are the changes needed?

To enforce the community guideline.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

![Screenshot 2023-12-07 at 7 40 54 PM](https://github.com/apache/spark/assets/9700541/7777b23f-d8be-410a-bc61-88f8b477a3b0)

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#44246 from dongjoon-hyun/SPARK-46316.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants