[SPARK-46438][UI] Fix the broken scope of toggleFramegraph when registering onclick event for the Frame Graph header#44394
Closed
yaooqinn wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-46438][UI] Fix the broken scope of toggleFramegraph when registering onclick event for the Frame Graph header#44394yaooqinn wants to merge 3 commits intoapache:masterfrom
yaooqinn wants to merge 3 commits intoapache:masterfrom
Conversation
…tering onclick event for the Frame Graph header
…tering onclick event for the Frame Graph header
Member
Author
| expect($("[name=spark] title").html()).toBe('spark (50.000%, 1 samples)'); | ||
| }); | ||
|
|
||
| test('toggleFlamegraph', function () { |
dongjoon-hyun
approved these changes
Dec 18, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM.
Merged to master.
Member
Author
|
Thank you @dongjoon-hyun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the broken scope of toggleFramegraph when registering onclick event for the Frame Graph header. Otherwise, the Frame Graph cannot be collapsed.
Why are the changes needed?
bugfix for UI.
Does this PR introduce any user-facing change?
no
How was this patch tested?
added a new test for toggleFramegraph in ui-tests.
Was this patch authored or co-authored using generative AI tooling?
no