[SPARK-46447][SQL] Remove the legacy datetime rebasing SQL configs#44402
Closed
MaxGekk wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-46447][SQL] Remove the legacy datetime rebasing SQL configs#44402MaxGekk wants to merge 4 commits intoapache:masterfrom
MaxGekk wants to merge 4 commits intoapache:masterfrom
Conversation
MaxGekk
changed the title
MaxGekk
changed the title
Member
|
cc @gatorsmile for this removal |
Member
Author
|
Please, don't merge this. I need to double check one thing. |
MaxGekk
changed the title
MaxGekk
changed the title
Member
Author
|
I have excluded the legacy SQL config spark.sql.legacy.parquet.datetimeRebaseModeInRead from this PR because I do believe that users might face to it in the wild. @HyukjinKwon @cloud-fan @dbatomic @sadikovi Could you take a look at the PR too, please. |
cloud-fan
approved these changes
Dec 20, 2023
Member
Author
|
Merging to master. Thank you, @yaooqinn @dongjoon-hyun @cloud-fan for review. |
Member
|
Thank you, @MaxGekk and all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to remove already deprecated SQL configs (alternatives to other configs):
Why are the changes needed?
To improve code maintenance.
Does this PR introduce any user-facing change?
Should not.
How was this patch tested?
By existing test suites.
Was this patch authored or co-authored using generative AI tooling?
No.