[SPARK-46563][SQL] View simpleString not follow conf spark.sql.debug.maxToStringFields#44558
Closed
AngersZhuuuu wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-46563][SQL] View simpleString not follow conf spark.sql.debug.maxToStringFields#44558AngersZhuuuu wants to merge 3 commits intoapache:masterfrom
AngersZhuuuu wants to merge 3 commits intoapache:masterfrom
Conversation
…maxToStringFields
MaxGekk
reviewed
Jan 2, 2024
Member
MaxGekk
left a comment
There was a problem hiding this comment.
@AngersZhuuuu Could you check other places, please. I have found a couple more places where we could restrict the number of outputted fields:
case class ExternalRDDScanExec[T](
...
override def simpleString(maxFields: Int): String = {
s"$nodeName${output.mkString("[", ",", "]")}"
}and
case class UnresolvedTableSpec(
...
override def simpleString(maxFields: Int): String = {
this.copy(properties = Utils.redact(properties).toMap).toString
}
Contributor
Author
Yea, let me check |
Contributor
Author
|
Checked all and done |
yaooqinn
approved these changes
Jan 2, 2024
HyukjinKwon
approved these changes
Jan 3, 2024
Contributor
Author
|
The remain failed GA seems not related? |
Member
Seems not. +1, LGTM. Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
View simpleString not follow conf spark.sql.debug.maxToStringFields
Why are the changes needed?
When columns is too much, the info is noisy. View simpleString not follow conf spark.sql.debug.maxToStringFields
Does this PR introduce any user-facing change?
Yea, view's plan will follow
spark.sql.debug.maxToStringFieldsHow was this patch tested?
No
Was this patch authored or co-authored using generative AI tooling?
No