Skip to content

[SPARK-46653][SQL] Code-gen for full outer sort merge join output row by row #44660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zml1206 wants to merge 2 commits into from
Closed

[SPARK-46653][SQL] Code-gen for full outer sort merge join output row by row #44660

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e244d2
Fix oom by code-gen for full outer sort merge join
zml1206 Jan 9, 2024
f34e0a5
wrap "$matchRowsInBuffer" as a function
zml1206 Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 51 additions & 28 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,8 +815,10 @@ case class SortMergeJoinExec(
v => s"$v = new $matchedClsName(1);", forceInline = true)
val rightMatched = ctx.addMutableState(matchedClsName, "rightMatched",
v => s"$v = new $matchedClsName(1);", forceInline = true)
val leftIndex = ctx.freshName("leftIndex")
val rightIndex = ctx.freshName("rightIndex")
val leftIndex = ctx.addMutableState(CodeGenerator.JAVA_INT, "leftIndex",
v => s"$v = 0;", forceInline = true)
val rightIndex = ctx.addMutableState(CodeGenerator.JAVA_INT, "rightIndex",
v => s"$v = 0;", forceInline = true)

// Generate code for join condition
val leftResultVars = genOneSideJoinVars(
Expand Down Expand Up @@ -878,6 +880,8 @@ case class SortMergeJoinExec(
| int comp = 0;
| $leftBuffer.clear();
| $rightBuffer.clear();
| $leftIndex = 0;
| $rightIndex = 0;
|
| if ($leftInputRow == null) {
| $leftInputRow = (InternalRow) leftIter.next();
Expand Down Expand Up @@ -957,44 +961,63 @@ case class SortMergeJoinExec(
""".stripMargin)

// Scan the left and right buffers to find all matched rows.
val matchRowsInBuffer =
val matchRowsInBufferFuncName = ctx.freshName("matchRowsInBuffer")
ctx.addNewFunction(matchRowsInBufferFuncName,
s"""
|int $leftIndex;
|int $rightIndex;
|
|for ($leftIndex = 0; $leftIndex < $leftBuffer.size(); $leftIndex++) {
| $leftOutputRow = (InternalRow) $leftBuffer.get($leftIndex);
| for ($rightIndex = 0; $rightIndex < $rightBuffer.size(); $rightIndex++) {
| $rightOutputRow = (InternalRow) $rightBuffer.get($rightIndex);
| $conditionCheck {
|private boolean $matchRowsInBufferFuncName() throws java.io.IOException {
| while ($leftIndex < $leftBuffer.size()) {
| $leftOutputRow = (InternalRow) $leftBuffer.get($leftIndex);
| while ($rightIndex < $rightBuffer.size()) {
| $rightOutputRow = (InternalRow) $rightBuffer.get($rightIndex);
| $conditionCheck {
| $consumeFullOuterJoinRow();
| $leftMatched.set($leftIndex);
| $rightMatched.set($rightIndex);
| if (shouldStop()) {
| $rightIndex++;
| return true;
| }
| }
| $rightIndex++;
| }
| $rightIndex = 0;
| if (!$leftMatched.get($leftIndex)) {
| $rightOutputRow = null;
| $consumeFullOuterJoinRow();
| $leftMatched.set($leftIndex);
| $rightMatched.set($rightIndex);
| if (shouldStop()) {
| $leftIndex++;
| return true;
| }
| }
| $leftIndex++;
| }
|
| if (!$leftMatched.get($leftIndex)) {
|
| $rightOutputRow = null;
| $consumeFullOuterJoinRow();
| }
|}
|
|$leftOutputRow = null;
|for ($rightIndex = 0; $rightIndex < $rightBuffer.size(); $rightIndex++) {
| if (!$rightMatched.get($rightIndex)) {
| // The right row has never matched any left row, join it with null row
| $rightOutputRow = (InternalRow) $rightBuffer.get($rightIndex);
| $consumeFullOuterJoinRow();
| $leftOutputRow = null;
| while ($rightIndex < $rightBuffer.size()) {
| if (!$rightMatched.get($rightIndex)) {
| // The right row has never matched any left row, join it with null row
| $rightOutputRow = (InternalRow) $rightBuffer.get($rightIndex);
| $consumeFullOuterJoinRow();
| if (shouldStop()) {
| $rightIndex++;
| return true;
| }
| }
| $rightIndex++;
| }
| return false;
|}
""".stripMargin
""".stripMargin)

s"""
|// If we already buffered some matching rows, use them directly
|if ($leftIndex < $leftBuffer.size() || $rightIndex < $rightBuffer.size()) {
| if($matchRowsInBufferFuncName()) return;
|}
|while (($leftInputRow != null || $leftInput.hasNext()) &&
| ($rightInputRow != null || $rightInput.hasNext())) {
| $findNextJoinRowsFuncName($leftInput, $rightInput);
| $matchRowsInBuffer
| $matchRowsInBufferFuncName();
| if (shouldStop()) return;
|}
|
Expand Down