[SPARK-46711][SS] Fix RocksDB state provider race condition during rollback#44722
Closed
anishshri-db wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-46711][SS] Fix RocksDB state provider race condition during rollback#44722anishshri-db wants to merge 2 commits intoapache:masterfrom
anishshri-db wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
cc - @HeartSaVioR - PTAL. thx ! |
Contributor
Author
|
Linter job failure seems unrelated. Seems to be failing for other PRs too |
Contributor
|
Linter failure is not related to this change. Thanks! Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix RocksDB state provider race condition during rollback
Why are the changes needed?
The rollback() method in RocksDB is not properly synchronized, thus a race condition can be introduced during rollback when there are tasks trying to commit.
The symptom of the race condition is the following exception being thrown:
This race condition can happen for the following sequence of events
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit tests
Was this patch authored or co-authored using generative AI tooling?
No