[SPARK-46722][CONNECT] Add a test regarding to backward compatibility check for StreamingQueryListener in Spark Connect (Scala/PySpark)#44736
Closed
HeartSaVioR wants to merge 4 commits intoapache:masterfrom
Closed
Conversation
HeartSaVioR
commented
Jan 15, 2024
Contributor
Author
There was a problem hiding this comment.
This is just an indentation change, with receiving test_listener from outside of the method.
… check for StreamingQueryListener in Spark Connect (Scala/PySpark)
HeartSaVioR
force-pushed
the
SPARK-46722
branch
from
7590c07 to
aa091f8
Compare
Contributor
Author
|
cc. @zsxwing @viirya @anishshri-db @HyukjinKwon Please take a look. Thanks! |
HyukjinKwon
approved these changes
Jan 16, 2024
Contributor
Author
|
Thanks! Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add a functionality to perform backward compatibility check for StreamingQueryListener in Spark Connect (both Scala and PySpark), specifically implementing onQueryIdle or not.
Why are the changes needed?
We missed to add backward compatibility test when introducing onQueryIdle, and it led to an issue in PySpark (https://issues.apache.org/jira/browse/SPARK-45631). We added the compatibility test in PySpark but didn't add it in Spark Connect.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Modified UTs.
Was this patch authored or co-authored using generative AI tooling?
No.