[SPARK-46727][SQL] Port classifyException() in JDBC dialects on error classes#44739
Closed
MaxGekk wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-46727][SQL] Port classifyException() in JDBC dialects on error classes#44739MaxGekk wants to merge 3 commits intoapache:masterfrom
classifyException() in JDBC dialects on error classes#44739MaxGekk wants to merge 3 commits intoapache:masterfrom
Conversation
MaxGekk
changed the title
classifyException() in JDBC dialects on error classesclassifyException() in JDBC dialects on error classes
Member
Author
|
cc @milastdbx |
cloud-fan
approved these changes
Jan 16, 2024
beliefer
approved these changes
Jan 16, 2024
Contributor
beliefer
left a comment
beliefer
left a comment
There was a problem hiding this comment.
LGTM except one comment.
| val regex = "(?s)Failed to create index (.*) in (.*)".r | ||
| val indexName = regex.findFirstMatchIn(message).get.group(1) | ||
| val tableName = regex.findFirstMatchIn(message).get.group(2) | ||
| case 42111 if errorClass == "FAILED_JDBC.CREATE_INDEX" => |
Contributor
There was a problem hiding this comment.
Is there only need error code?
Member
Author
There was a problem hiding this comment.
It is some kind of a guard for accessing messageParameters. Previous implementation implicitly assumes that the error happens on creating an index, see the regexp. Here I just made the assumption explicit.
Member
Author
|
Merging to master. Thank you, @beliefer and @cloud-fan for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to port the existing
classifyException()method which accepts a description to new one w/ an error class added by #44358. The modified JDBC dialects are: DB2, H2, Oracle, MS SQL Server, MySQL and PostgreSQL.Why are the changes needed?
The old method
classifyException()which accepts adescriptiononly has been deprecated already by ...Does this PR introduce any user-facing change?
No.
How was this patch tested?
By existing integration tests, and the modified test suite:
Was this patch authored or co-authored using generative AI tooling?
No.