[SPARK-46855][INFRA][3.4] Add sketch to the dependencies of the catalyst in module.py#44894
Closed
LuciferYang wants to merge 1 commit intoapache:branch-3.4from
Closed
[SPARK-46855][INFRA][3.4] Add sketch to the dependencies of the catalyst in module.py#44894LuciferYang wants to merge 1 commit intoapache:branch-3.4from
sketch to the dependencies of the catalyst in module.py#44894LuciferYang wants to merge 1 commit intoapache:branch-3.4from
Conversation
Contributor
Author
|
cc @dongjoon-hyun ~ |
zhengruifeng
approved these changes
Jan 26, 2024
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 26, 2024
…talyst` in `module.py` ### What changes were proposed in this pull request? This pr add `sketch` to the dependencies of the `catalyst` module in `module.py` due to `sketch` is direct dependency of `catalyst` module. ### Why are the changes needed? Ensure that when modifying the `sketch` module, both `catalyst` and cascading modules will trigger tests. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #44894 from LuciferYang/SPARK-46855-34. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Merged to branch-3.4. |
Contributor
Author
|
Thanks @dongjoon-hyun @zhengruifeng |
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Feb 7, 2024
…talyst` in `module.py` ### What changes were proposed in this pull request? This pr add `sketch` to the dependencies of the `catalyst` module in `module.py` due to `sketch` is direct dependency of `catalyst` module. ### Why are the changes needed? Ensure that when modifying the `sketch` module, both `catalyst` and cascading modules will trigger tests. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#44894 from LuciferYang/SPARK-46855-34. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr add
sketchto the dependencies of thecatalystmodule inmodule.pydue tosketchis direct dependency ofcatalystmodule.Why are the changes needed?
Ensure that when modifying the
sketchmodule, bothcatalystand cascading modules will trigger tests.Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No