Skip to content

[SPARK-46896][PS][TESTS] Clean up the imports in pyspark.pandas.tests.{frame, series, groupby}.*#44922

Closed
zhengruifeng wants to merge 5 commits intoapache:masterfrom
zhengruifeng:ps_test_frame_ser_cleanup
Closed

[SPARK-46896][PS][TESTS] Clean up the imports in pyspark.pandas.tests.{frame, series, groupby}.*#44922
zhengruifeng wants to merge 5 commits intoapache:masterfrom
zhengruifeng:ps_test_frame_ser_cleanup

Conversation

@zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

1, remove unused imports;
2, only define the test datasets once in the vanilla side, so that won't need to define it again in the parity tests;

Why are the changes needed?

code clean up

Does this PR introduce any user-facing change?

no, test-only

How was this patch tested?

ci

Was this patch authored or co-authored using generative AI tooling?

no

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM if CI passes.

@zhengruifeng
Copy link
Contributor Author

thanks, merged to master

@zhengruifeng zhengruifeng deleted the ps_test_frame_ser_cleanup branch January 29, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments